Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(tracing): Deprecate propagate_traces option. #3899

Conversation

mgaligniana
Copy link
Contributor

@mgaligniana mgaligniana commented Jan 3, 2025

The option is not documented and it is True by default. We should deprecated it and remove in the next major.

This option was later superseded by trace_propagation_targets.

Fixes GH-3106

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.21%. Comparing base (9ff100a) to head (f7acd02).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3899      +/-   ##
==========================================
+ Coverage   80.15%   80.21%   +0.06%     
==========================================
  Files         139      139              
  Lines       15391    15394       +3     
  Branches     2596     2596              
==========================================
+ Hits        12337    12349      +12     
+ Misses       2208     2202       -6     
+ Partials      846      843       -3     
Files with missing lines Coverage Δ
sentry_sdk/integrations/celery/__init__.py 86.66% <100.00%> (+0.11%) ⬆️
sentry_sdk/scope.py 85.45% <100.00%> (+0.30%) ⬆️

... and 3 files with indirect coverage changes

@mgaligniana mgaligniana force-pushed the GH-3106-add-deprecation-warning-to-propagate-traces-option branch 2 times, most recently from 5e15320 to fb72ce0 Compare January 3, 2025 12:33
@mgaligniana mgaligniana force-pushed the GH-3106-add-deprecation-warning-to-propagate-traces-option branch from fb72ce0 to ecb8dd7 Compare January 3, 2025 12:35
@antonpirker antonpirker added the Trigger: tests using secrets PR code is safe; run CI label Jan 14, 2025
@antonpirker antonpirker enabled auto-merge (squash) January 14, 2025 13:20
@antonpirker antonpirker changed the title feat(tracing): Add propagate_traces deprecation warning ref(tracing): Add propagate_traces deprecation warning Jan 14, 2025
@antonpirker antonpirker changed the title ref(tracing): Add propagate_traces deprecation warning ref(tracing): Deprecate propagate_traces option. Jan 14, 2025
@github-actions github-actions bot removed the Trigger: tests using secrets PR code is safe; run CI label Jan 14, 2025
@antonpirker antonpirker added the Trigger: tests using secrets PR code is safe; run CI label Jan 14, 2025
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the contribution!

@antonpirker antonpirker merged commit 8a70b76 into getsentry:master Jan 14, 2025
146 of 148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger: tests using secrets PR code is safe; run CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate undocumented propagate_traces option
2 participants